Remove BreezeLambdaService #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Andrea-Scuderi
commented
Oct 2, 2025
Andrea-Scuderi
commented
- Remove redundant BreezeLambdaService
|
Graceful shutdown logs: |
sebsto
reviewed
Oct 2, 2025
| return self.dbManager | ||
| public func run() async throws { | ||
| try await gracefulShutdown() | ||
| try await onGracefulShutdown() |
There was a problem hiding this comment.
Are you shutting down immediately at run() ? Does it work ? Why ?
There was a problem hiding this comment.
The function try await gracefulShutdown() waits until graceful shutdown is triggered as documented in ServiceLifecycle
sebsto
reviewed
Oct 2, 2025
| do { | ||
| try await serviceGroup.run() | ||
| } catch { | ||
| try dynamoDBService.syncShutdown() |
There was a problem hiding this comment.
I think the life cycle group must do that. You should not shutdown() or cancel() a service part of the group
There was a problem hiding this comment.
I agree, it does unless there is a failure condition. Without this BreezeLambdaAPITests will crash.
I'll check if there is a better way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.