Merge pull request #6422 from adrian-prantl/106464908

adrian-prantl · web-flow · commit 670b79bf9ad7 · 2023-03-09T13:37:42.000-08:00
Pass argument by reference to a void a use-after-free.
diff --git a/lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp b/lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
@@ -3369,7 +3369,7 @@ CompilerType TypeSystemSwiftTypeRef::CreateSILPackType(CompilerType type,
 }
 
 static llvm::Optional<TypeSystemSwiftTypeRef::PackTypeInfo>
-decodeSILPackType(swift::Demangle::Demangler dem, CompilerType type,
+decodeSILPackType(swift::Demangle::Demangler &dem, CompilerType type,
                   swift::Demangle::NodePointer &node) {
   TypeSystemSwiftTypeRef::PackTypeInfo info;
   node = GetDemangledType(dem, type.GetMangledTypeName().GetStringRef());

Original file line number	Diff line number	Diff line change
`@@ -3369,7 +3369,7 @@ CompilerType TypeSystemSwiftTypeRef::CreateSILPackType(CompilerType type,`
`3369`	`3369`	`}`
`3370`	`3370`
`3371`	`3371`	`static llvm::Optional<TypeSystemSwiftTypeRef::PackTypeInfo>`
`3372`		`-decodeSILPackType(swift::Demangle::Demangler dem, CompilerType type,`
	`3372`	`+decodeSILPackType(swift::Demangle::Demangler &dem, CompilerType type,`
`3373`	`3373`	`swift::Demangle::NodePointer &node) {`
`3374`	`3374`	`TypeSystemSwiftTypeRef::PackTypeInfo info;`
`3375`	`3375`	`node = GetDemangledType(dem, type.GetMangledTypeName().GetStringRef());`