[🍒][Modules] Fix cyclic module dependencies in clang #10216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breakup the cyclic dependency in module 'Clang_Frontend': Clang_Frontend -> Clang_Serialization -> Clang_Frontend (cherry picked from commit 61c0a6d)
Author
|
@swift-ci please test |
Author
|
@swift-ci please test llvm |
cyndyishida
approved these changes
Mar 10, 2025
cyndyishida
left a comment
cyndyishida
left a comment
There was a problem hiding this comment.
LGTM, as this is to fix failing CI bots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breakup the cyclic dependency in module 'Clang_Frontend': Clang_Frontend -> Clang_Serialization -> Clang_Frontend
(cherry picked from commit 61c0a6d)
-DLLVM_ENABLE_MODULES=1after the change in [clang][deps] Remove dependency on llvm targets from lib DependencyScanning llvm/llvm-project#129774. The build breakage was missed because no public CI runs with modules enabled.