Skip to content

[lldb] Reduce max-children-depth default for readability #10683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

[lldb] Reduce max-children-depth default for readability #10683

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6fb64d
[lldb] Reduce max-children-depth default for readability
kastiglione May 14, 2025
a3898ed
Fix tests for max-children-depth
kastiglione May 14, 2025
9eda2f9
Fix test/Shell/SymbolFile/PDB/udt-layout.test
kastiglione May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Target/TargetProperties.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ let Definition = "target" in {
DefaultUnsignedValue<256>,
Desc<"Maximum number of children to expand in any level of depth.">;
def MaxChildrenDepth: Property<"max-children-depth", "UInt64">,
DefaultUnsignedValue<6>,
DefaultUnsignedValue<4>,
Desc<"Maximum depth to expand children.">;
def MaxSummaryLength: Property<"max-string-summary-length", "UInt64">,
DefaultUnsignedValue<1024>,
Expand Down
4 changes: 2 additions & 2 deletions lldb/test/API/functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,13 +357,13 @@ def cleanup():
self.runCmd("type format delete int")

# First, check the following:
# 1. Verify the default max-children-depth (6) is applied
# 1. Verify the default max-children-depth (4) is applied
# 2. Ensure the one-time warning is printed
warning = "*** Some of the displayed variables have a greater depth"
self.expect(
"frame variable quite_nested",
matching=True,
substrs=["six ={...}", warning],
substrs=["four ={...}", warning],
)
self.expect(
"frame variable quite_nested",
Expand Down
2 changes: 2 additions & 0 deletions lldb/test/API/functionalities/data-formatter/nsdictionarysynth/TestNSDictionarySynthetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ def cleanup():
'@"2 elements"',
],
)

self.runCmd("settings set target.max-children-depth 6")
self.expect(
"frame variable mutabledict --ptr-depth 3",
substrs=[
Expand Down