Cherry-pick [Modules] Record whether VarDecl initializers contain side effects (#143739) #10825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please test |
…lvm#143739) Calling `DeclMustBeEmitted` should not lead to more deserialization, as it may occur before previous deserialization has finished. When passed a `VarDecl` with an initializer however, `DeclMustBeEmitted` needs to know whether that initializer contains side effects. When the `VarDecl` is deserialized but the initializer is not, this triggers deserialization of the initializer. To avoid this we add a bit to the serialization format for `VarDecl`s, indicating whether its initializer contains side effects or not, so that the `ASTReader` can query this information directly without deserializing the initializer. rdar://153085264 This is a cherry-pick of 319a51a
hnrklssn
force-pushed
the
remove-deserialize-assert
branch
from
5bace4c to
c8d3e93
Compare
hnrklssn
changed the title
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test llvm |
Normally expressions passed to EvaluateInPlace have a type, but not when a VarDecl initializer is evaluated before the untyped ParenListExpr is replaced with a CXXConstructExpr. This can happen in LLDB. In these cases consteval fails.
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test macos |
1 similar comment
Member
Author
|
@swift-ci please test macos |
Member
Author
|
Closed in favour of #10925 targeting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.