[clang][Modules] Reporting Errors for Duplicating Link Declarations i… #11265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `modulemap`s (llvm#148959) This PR teaches the modulemap parsing logic to report warnings that default to errors if the parsing logic sees duplicating link declarations in the same module. Specifically, duplicating link declarations means multiple link declarations with the same string-literal in the same module. No errors are reported if a same link declaration exist in a submodule and its enclosing module. The warning can be disabled with `-Wno-module-link-redeclaration`. rdar://155880064 (cherry picked from commit 538e9e8)
AnthonyLatsis
added a commit
to swiftlang/swift
that referenced
this pull request
Aug 29, 2025
… in implicit modulemaps swiftlang/llvm-project#11265 broke Windows CI for rebranch because our Windows modulemaps contain implicit submodules with link declarations. This is a temporary workaround to unblock investigation on any downstream issues.
qiongsiwu
added a commit
that referenced
this pull request
Sep 2, 2025
…ations in `modulemap`s (llvm#148959) (#11265)" (#11310) This reverts commit b11f60b. We found a problem with the link decl checks when testing for Windows rebranching. Temporarily revert the checks. rdar://159467837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n
modulemaps (llvm#148959)This PR teaches the modulemap parsing logic to report warnings that default to errors if the parsing logic sees duplicating link declarations in the same module. Specifically, duplicating link declarations means multiple link declarations with the same string-literal in the same module. No errors are reported if a same link declaration exist in a submodule and its enclosing module.
The warning can be disabled with
-Wno-module-link-redeclaration.rdar://155880064
(cherry picked from commit 538e9e8)