-
Notifications
You must be signed in to change notification settings - Fork 349
CAS fixes for clang cl mode. #11568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAS fixes for clang cl mode. #11568
Conversation
@swift-ci please test llvm |
Existing failures
eg. https://ci.swift.org/job/pr-apple-llvm-project-llvm-linux/1071/consoleText |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add test case for CL mode?
Done. PTAL |
@swift-ci please test llvm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool LGTM.
Three changes: - Make depscan flags visible. - Fix an issue that a depscan reponse file is written in the current directory without a unique id/hash in its path, collides with another for an identical source file and causes a build error. - Fix an issue that causes unexpected cas cache misses due to a temp depscan reponse file path (with a unique id/hash) being specified (incorrectly/unnecessarily) specified as the output object file (the -object-file-name flag) when for code view / pdb debug info is emitted.
@swift-ci please test llvm |
For some reason, some flags didn't work on macos and the test failed while it passes on Linux. I found a style of flags that works for macos/Linux/Windows and updated the test. Please take another look @cachemeifyoucan
|
LGTM |
Three changes: