Skip to content

[lldb] Update TestSwiftPOValTypes.py #11570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: stable/21.x
Choose a base branch
from
+9 −8
Open

[lldb] Update TestSwiftPOValTypes.py #11570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da07f6e
[lldb] Update TestSwiftPOValTypes.py
kastiglione Oct 5, 2025
2a61448
Prevent matching any "b"
kastiglione Oct 5, 2025
bc0ec18
Add missing return
kastiglione Oct 6, 2025
d2fef76
Simplify the changes
kastiglione Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lldb/test/API/lang/swift/po/val_types/TestSwiftPOValTypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,18 @@ def test_value_types(self):
"""Test 'po' on a variety of value types with and without custom descriptions."""
self.build()
(_,_,_,_) = lldbutil.run_to_source_breakpoint(self, "Break here to run tests", lldb.SBFileSpec("main.swift"))

self.expect("po dm", substrs=['a', '12', 'b', '24'])
self.expect("po cm", substrs=['c', '36'])
self.expect("po cm", substrs=['12', '24'], matching=False)
self.expect("po cs", substrs=['CustomDebugStringConvertible'])
self.expect("po cs", substrs=['CustomStringConvertible'], matching=False)
self.expect("po cs", substrs=['a', '12', 'b', '24'])
self.expect("script lldb.frame.FindVariable('cs').GetObjectDescription()", substrs=['a', '12', 'b', '24'])
self.expect("po cs", substrs=["abc", "12", "def", "24"], matching=False)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does matching=False do?

Copy link
Author

@kastiglione kastiglione Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It tests that the substrings are not found in the output.

With the updated behavior in swiftlang/swift#84677, the properties (abc, def) should not be shown because the type conforms to CustomStringConvertible/CustomDebugStringConvertible.

self.expect(
"script lldb.frame.FindVariable('cs').GetObjectDescription()",
patterns=["abc", "12", "def", "24"],
matching=False,
)
self.expect("po (12,24,36,48)", substrs=['12', '24', '36', '48'])
self.expect("po (dm as Any, cm as Any,48 as Any)", substrs=['12', '24', '36', '48'])
self.expect("po patatino", substrs=['foo'])
Expand All @@ -46,6 +50,3 @@ def test_ignore_bkpts_in_po(self):
# As part of the po expression we should auto-continue past the breakpoint so this succeeds:
self.expect("po cs", substrs=['CustomDebugStringConvertible'])
self.assertEqual(po_bkpt.GetHitCount(), 1, "Did hit the breakpoint")



4 changes: 2 additions & 2 deletions lldb/test/API/lang/swift/po/val_types/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ struct CustomMirror : CustomReflectable {
}

struct CustomSummary : CustomStringConvertible, CustomDebugStringConvertible {
var a = 12
var b = 24
var abc = 12
var def = 24

var description: String {
return "CustomStringConvertible"
Expand Down