Skip to content

[lldb] Rework IRExecutionUnit to avoid lookup in JIT module #11873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: swift/release/6.3
Choose a base branch
from
Open

[lldb] Rework IRExecutionUnit to avoid lookup in JIT module #11873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions lldb/source/Expression/IRExecutionUnit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,12 @@ IRExecutionUnit::FindInSymbols(const std::vector<ConstString> &names,
for (size_t i = 0; i < m_preferred_modules.GetSize(); ++i)
non_local_images.Remove(m_preferred_modules.GetModuleAtIndex(i));

// BEGIN SWIFT
if (m_in_populate_symtab)
if (lldb::ModuleSP jit_module_sp = m_jit_module_wp.lock())
non_local_images.Remove(jit_module_sp);
// END SWIFT

LoadAddressResolver resolver(*target, symbol_was_missing_weak);

ModuleFunctionSearchOptions function_options;
Expand All @@ -840,15 +846,6 @@ IRExecutionUnit::FindInSymbols(const std::vector<ConstString> &names,
return *load_addr;
}

if (sc.target_sp) {
ModuleList images = sc.target_sp->GetImages();
// BEGIN SWIFT
if (m_in_populate_symtab)
if (lldb::ModuleSP module_sp = m_jit_module_wp.lock())
images.Remove(module_sp);
// END SWIFT
}

{
SymbolContextList sc_list;
m_preferred_modules.FindFunctions(name, lldb::eFunctionNameTypeFull,
Expand Down