[Support] Include intrin.h for MSVC intrinsics in xxhash.cpp
#9228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__umulh` added in llvm#95863 requires `intrin.h`, make sure to include it.
|
@swift-ci please test |
|
@compnerd I'll push this upstream if it ends up passing on arm64 |
compnerd
approved these changes
Sep 7, 2024
|
No arm64 testing... just going to merge and will keep an eye on the arm64 job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__umulhadded in llvm#95863 requiresintrin.h, make sure to include it.