[🍒 swift/release/6.1] [llvm][AArch64] Fix a crash in performPostLD1Combine #9701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://138004275 (cherry picked from commit b61d3cc)
Author
|
@swift-ci test |
Author
|
@swift-ci test windows |
jroelofs
changed the title
Author
|
@swift-ci test linux |
Author
|
@swift-ci test windows |
jroelofs
force-pushed
the
jroelofs/6.1-cherrypicks
branch
from
eb25d1e to
0dbf825
Compare
Author
|
@swift-ci test |
Author
|
@swift-ci test windows |
jroelofs
changed the title
Author
|
@swift-ci test macos |
aemerson
approved these changes
Dec 13, 2024
tbkka
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of llvm#118538
The combine was attempting to replace a load that already had index writeback, resulting in an incorrect CombineTo, which would have changed the number of SDValue results of the instruction. The fix is to skip forming the LD1 combine when the load is already an indexed one.
• Risk: Low, this change turns an assertion failure / crash into a skipped optimization.
• Testing: Updated regression tests
• Reviewed by: @aemerson
• Original PR: llvm#118538
• Radar: rdar://138004275