Don’t enter an infinite loop when a circular symlink is added to a project #2064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
hamishknight
approved these changes
Mar 14, 2025
bnbarham
approved these changes
Mar 14, 2025
ahoppen
force-pushed
the
circular-symlinks
branch
from
76de023 to
c2e0b3d
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test |
ahoppen
force-pushed
the
circular-symlinks
branch
from
c2e0b3d to
b74d934
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
circular-symlinks
branch
from
b74d934 to
a76f572
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that we infinite loop here after reviewing swiftlang/swift-format#947.