Skip to content

[6.2] Update for new ExpandEditorPlaceholdersToLiteralClosures API #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

hamishknight
Copy link
Contributor

6.2 cherry-pick of #2170

  • Explanation: Updates sourcekit-lsp for a new swift-syntax API
  • Scope: NFC
  • Issue: rdar://152711580
  • Risk: Low, this is an NFC change
  • Testing: Added tests to test suite
  • Reviewer: Alex Hoppen, Ben Barham

This refactoring now takes a `Syntax` parameter. We don't actually
need to change anything else to handle placeholder expansion for
macro expansion completions since they get parsed as function calls.
@hamishknight hamishknight requested a review from a team as a code owner June 6, 2025 18:13
@hamishknight hamishknight requested a review from bnbarham June 6, 2025 18:13
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight
Copy link
Contributor Author

@swift-ci please test macOS

@hamishknight hamishknight enabled auto-merge June 7, 2025 09:47
@hamishknight hamishknight disabled auto-merge June 7, 2025 09:47
@hamishknight hamishknight enabled auto-merge June 7, 2025 09:47
@hamishknight hamishknight merged commit 38420b6 into swiftlang:release/6.2 Jun 7, 2025
3 checks passed
@hamishknight hamishknight deleted the place-mac-6.2 branch June 7, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants