[DocC Live Preview] Cache on-disk snapshots opened in sourcekitd #2226
+207
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test windows |
ahoppen
reviewed
Aug 4, 2025
| /// - Parameter symbolLocation: The location of a symbol to find the symbol graph for. | ||
| /// - Returns: The symbol graph for this location, if any. | ||
| func fetchSymbolGraph(at symbolLocation: SymbolLocation) async throws -> String? { | ||
| let swiftLanguageService = try await swiftLanguageService(for: symbolLocation.documentUri) |
There was a problem hiding this comment.
I think we’re never re-using an open document, are we? I don’t even think that we ever register open documents.
There was a problem hiding this comment.
I must have slipped into a coma or something while writing this... Good catch!
matthewbastien
force-pushed
the
docc-cache-snapshots
branch
from
73115b1 to
1a6b818
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
SwiftLanguageService.withSnapshotFromDiskOpenedInSourcekitd()in favor of a newOnDiskDocumentManageractor that will cache all snapshots opened for the duration of atextDocument/doccDocumentationrequest. This will prevent the syntax tree from being parsed multiple times for the same document in a single request.Follow up to #2216