Move SwiftLanguageService into its own module
#2234
+1,464
−1,188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
bnbarham
approved these changes
Aug 11, 2025
| @@ -171,6 +181,13 @@ package protocol LanguageService: AnyObject, Sendable { | |||
| #endif | |||
| func symbolInfo(_ request: SymbolInfoRequest) async throws -> [SymbolDetails] | |||
|
|
|||
| /// Return the symbol graph at the given location for the contents of the document as they are on-disk (opposed ot the | |||
There was a problem hiding this comment.
Suggested change
| /// Return the symbol graph at the given location for the contents of the document as they are on-disk (opposed ot the | |
| /// Return the symbol graph at the given location for the contents of the document as they are on-disk (opposed to the |
Sources/SourceKitLSP/Workspace.swift
Outdated
| } ?? [] | ||
| }) | ||
| self.syntacticTestIndex = SyntacticTestIndex( | ||
| languageServiceRegistry: sourceKitLSPServer?.languageServiceRegistry ?? LanguageServiceRegistry(), |
There was a problem hiding this comment.
IIUC this case only happens during tests, but it makes it seem like SourceKitLSPServer shouldn't be the owner of LanguageServiceRegistry 🤔
There was a problem hiding this comment.
There’s no reason why sourceKitLSPServer needs to be an optional here anyway. Updating it so that we always have a SourceKitLSPServer and then we don’t need the fallback here.
ahoppen
force-pushed
the
move-swiftlanguageservice
branch
2 times, most recently
from
134b99b to
e5908a7
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
reviewed
Aug 11, 2025
ahoppen
force-pushed
the
move-swiftlanguageservice
branch
from
e5908a7 to
37f9610
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
move-swiftlanguageservice
branch
from
37f9610 to
dfe1046
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
move-swiftlanguageservice
branch
from
dfe1046 to
f60ec7b
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the effort started in #2228.