Add support for the libswiftCompatibilitySpan.dylib backward deployment library #359
Conversation
slavapestov
requested review from
jakepetroules,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
|
This is a work-in-progress; I still want to add tests. Also the whole thing feels like a bunch of copy and paste. The problem is that "Swift in the OS" and "Swift concurrency" are two concepts plumbed through all these layers, and now I'm adding a third. Suggestions for improving this are welcome. |
slavapestov
force-pushed
the
compatibility-span
branch
from
32c3a6c to
414a184
Compare
| /// Minimum OS version for Swift concurrency (Swift 5.5). If this is `nil`, the platform does not support Swift concurrency at all. | ||
| fileprivate(set) var minimumOSForSwiftConcurrency: Version? = nil | ||
|
|
||
| /// Minimum OS version for Span in the standard library (Swift 6.2). If this is `nil`, the platform does not support Swift concurrency at all. |
There was a problem hiding this comment.
"the platform does not support Swift concurrency at all."
Think this needs to be updated to reflect Span, rather than Swift Concurrency
| } | ||
|
|
||
| /// Determines if the platform natively supports Swift 6.2's Span type. If `false`, then the Swift Span back-compat concurrency libs needs to be copied into the app/framework's bundle. | ||
| public func supportsSwiftSpanNatively(_ scope: MacroEvaluationScope, forceNextMajorVersion: Bool = false, considerTargetDeviceOSVersion: Bool = true) -> Bool? { |
There was a problem hiding this comment.
Why add default values for the arguments? This is only ever called in one place.
|
I found my way here after noticing that |
|
Closing in favor of #642 |
3 participants
No description provided.