Add an "upward" link library type for BuildDependencyInfo #456
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob-wilson
requested review from
jakepetroules,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
owenv
approved these changes
Apr 29, 2025
|
@swift-ci test |
jakepetroules
requested changes
Apr 29, 2025
There was a problem hiding this comment.
Test is failing:
✘ Test buildSettingsInputs() recorded an issue at BuildDependencyInfoTests.swift:407:25: Expectation failed: (input.libraryType → .dynamic) == .upward
↳ input.libraryType: SWBBuildService.BuildDependencyInfo.TargetDependencyInfo.Input.LibraryType → .dynamic
↳ .upward: SWBBuildService.BuildDependencyInfo.TargetDependencyInfo.Input.LibraryType → .upward
✘ Test buildSettingsInputs() failed after 36.319 seconds with 1 issue.
Upward linking is used when there would otherwise by a cyclic dependency so it is important to know that in the dependency information. rdar://143493388
bob-wilson
force-pushed
the
upward-link-deps
branch
from
5c6d72a to
efb2b10
Compare
|
@swift-ci test |
jakepetroules
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upward linking is used when there would otherwise by a cyclic dependency so it is important to know that in the dependency information.
rdar://143493388