Skip to content

Enable testing in GitHub Actions workflows #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Enable testing in GitHub Actions workflows #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c216ede
Skip tests which fail in the GitHub actions runner environment
owenv Apr 30, 2025
d5d7c0a
Run tests in GitHub actions workflows
owenv Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
with:
linux_os_versions: '["noble", "jammy", "focal", "rhel-ubi9"]'
linux_pre_build_command: command -v apt >/dev/null 2>&1 && apt update && apt install -y libsqlite3-dev libncurses-dev || (command -v yum >/dev/null 2>&1 && yum update -y && yum install -y sqlite-devel ncurses-devel)
linux_build_command: 'swift build'
linux_build_command: 'swift test --no-parallel'
linux_swift_versions: '["nightly-main", "nightly-6.2"]'
windows_swift_versions: '["nightly-main"]'
windows_build_command: 'swift build'
windows_build_command: 'swift test --no-parallel'
soundness:
name: Soundness
uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftBuildTests/ConsoleCommands/BuildCommandTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import SWBUtil
import Testing
import SwiftBuildTestSupport

@Suite(.skipHostOS(.windows))
@Suite(.skipHostOS(.windows), .skipInGitHubActions("failing in the GitHub actions runner environment"))
fileprivate struct BuildCommandTests {
private let commandSequenceCodec: any CommandSequenceEncodable = LLVMStyleCommandCodec()

Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftBuildTests/ConsoleCommands/CreateXCFrameworkCommandTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import SWBTestSupport

// Note: The functionality of this class is heavily unit tested in `XCFrameworkTests.swift`. These tests are only to ensure that the command is indeed hooked up and registered properly.

@Suite
@Suite(.skipInGitHubActions("failing in the GitHub actions runner environment"))
fileprivate struct CreateXCFrameworkCommandTests {
@Test
func commandInvocation() async throws {
Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftBuildTests/ConsoleCommands/GeneralCommandsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import SwiftBuild
import SWBTestSupport
import SWBUtil

@Suite
@Suite(.skipInGitHubActions("failing in the GitHub actions runner environment"))
fileprivate struct GeneralCommandsTests {
@Test(.skipHostOS(.windows), // PTY not supported on Windows
.requireHostOS(.macOS)) // something with terminal echo is different on macOS vs Linux
Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftBuildTests/ConsoleCommands/ServiceConsoleTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import SWBUtil
import WinSDK
#endif

@Suite
@Suite(.skipInGitHubActions("failing in the GitHub actions runner environment"))
fileprivate struct ServiceConsoleTests {
@Test
func emptyInput() async throws {
Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftBuildTests/ConsoleCommands/SessionCommandsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import SWBTestSupport
import Testing
import SWBUtil

@Suite
@Suite(.skipInGitHubActions("failing in the GitHub actions runner environment"))
fileprivate struct SessionCommandsTests {
@Test(.skipHostOS(.windows), // PTY not supported on Windows
.requireHostOS(.macOS)) // something with terminal echo is different on macOS vs Linux
Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftBuildTests/ConsoleCommands/XcodeCommandsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import SWBTestSupport
import Testing
import SWBUtil

@Suite
@Suite(.skipInGitHubActions("failing in the GitHub actions runner environment"))
fileprivate struct XcodeCommandsTests {
@Test(.skipHostOS(.windows), // PTY not supported on Windows
.requireHostOS(.macOS)) // something with terminal echo is different on macOS vs Linux
Expand Down