Avoid blocking a Swift Task in the read() syscall #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
aciidgh,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
|
@swift-ci test |
jakepetroules
force-pushed
the
eng/PR-no-block-read
branch
from
9d24231 to
5ab324e
Compare
|
@swift-ci test |
Add a DispatchIO-based helper which returns the data asynchronously.
jakepetroules
force-pushed
the
eng/PR-no-block-read
branch
from
5ab324e to
60a6735
Compare
|
@swift-ci test |
|
@swift-ci test macOS |
mirza-garibovic
approved these changes
Apr 30, 2025
|
@swift-ci test macOS |
jakepetroules
added a commit
to jakepetroules/swift-build
that referenced
this pull request
Jul 29, 2025
Some of these were formerly skipped in GitHub actions, but are passing now. Likely the culprit was ServiceConsoleTests.serviceShutdown all along, which is fixed in swiftlang#465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a DispatchIO-based helper which returns the data asynchronously.