[Swift] Add missing upcoming feature flags #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
xedin
changed the title
owenv
reviewed
Apr 30, 2025
| YES = ( "-enable-upcoming-feature", "NonisolatedNonsendingByDefault" ); | ||
| NO = (); | ||
| }; | ||
| DisplayName = "Nonisolated Nonsending By Default"; |
There was a problem hiding this comment.
Should Nonsending be Non-sending? Not sure how we've been spelling this elsewhere
There was a problem hiding this comment.
It's spelled as nonsending in the specifier.
There was a problem hiding this comment.
Could be different in the title, though then there's also Nonisolated 😅
owenv
approved these changes
Apr 30, 2025
|
@swift-ci please test Linux platform |
|
@swift-ci please test |
|
Let's lend this for now, we can rename later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two newly added feature flags were missing:
InferIsolatedConformancesNonisolatedNonsendingByDefaultResolves: rdar://problem/150397637