Respect entitlements file above build setting for build settings affe… #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cting entitlements. (150338157)
baujla
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
|
@swift-ci please test |
|
We will not be making this change, but rather we will stop implicitly setting the value for ENABLE_APP_SANDBOX In tests and will soften the warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so the sandbox and hardened runtime build setting will never overwrite a setting present in the entitlements file. This is a bad state for a project to be, hence why we've added warnings for this case exactly.
The entitlements file is the authority on what entitlements should be, while the build setting here is a convenience. In this case though, the build system is acting as an authority which based on feedback is quite confusing.