Ensure swift jobs with the same command line but different dependenci… #520
+163
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es aren't deduplicated This can happen if the Swift Driver plans the same job in two different builds, but specifies a differtent set of input dependencies which either remove up to date jobs or add out of date ones. Without this change, this could rarely lead to looking up the wrong set of or nonexistent input jobs in an incremental build following a failed or cancelled one
owenv
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic and
neonichu
as code owners
|
@swift-ci test |
jakepetroules
approved these changes
May 22, 2025
| public init(from deserializer: any Deserializer) throws { | ||
| try deserializer.beginAggregate(4) | ||
| try key = deserializer.deserialize() | ||
| try driverJob = deserializer.deserialize() |
There was a problem hiding this comment.
@owenv This missed changing 4 to 5 in deserialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es aren't deduplicated
This can happen if the Swift Driver plans the same job in two different builds, but specifies a differtent set of input dependencies which either remove up to date jobs or add out of date ones. Without this change, this could rarely lead to looking up the wrong set of or nonexistent input jobs in an incremental build following a failed or cancelled one
Fix this by incorporating the job dependencies in the key which uniquely identifies a job's dynamic task