🍒 Test the Isystem flag before using -Isystem #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-build needs to support older versions of swift-frontend that don't support -Isystem. Check the driver and front end before using it. Also set TEST_LIBRARY_SEARCH_PATHS in SWIFT_SYSTEM_INCLUDE_PATHS rather than SWIFT_INCLUDE_PATHS, to match the handling for TEST_FRAMEWORK_SEARCH_PATHS -> SYSTEM_FRAMEWORK_SEARCH_PATHS. rdar://152540600
ian-twilightcoder
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
owenv
approved these changes
Jun 4, 2025
ian-twilightcoder
merged commit 68d6704
into
swiftlang:release/6.2
20 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-build needs to support older versions of swift-frontend that don't support -Isystem. Check the driver and front end before using it. Also set TEST_LIBRARY_SEARCH_PATHS in SWIFT_SYSTEM_INCLUDE_PATHS rather than SWIFT_INCLUDE_PATHS, to match the handling for TEST_FRAMEWORK_SEARCH_PATHS -> SYSTEM_FRAMEWORK_SEARCH_PATHS.
rdar://152540600