Fix handling of multi-line XCConfig assignments #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally only one line was tracked here (the end line effectively), but we also have to track the start line separately for correct multi-line ranges.
neonichu
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic and
owenv
as code owners
|
@swift-ci please test |
| } | ||
|
|
||
| mutating func foundMacroValueAssignment(_ macroName: String, conditions: [(param: String, pattern: String)], value: String, path: Path, line: Int, startColumn: Int, endColumn: Int, parser: MacroConfigFileParser) { | ||
| mutating func foundMacroValueAssignment(_ macroName: String, conditions: [(param: String, pattern: String)], value: String, path: Path, startLine: Int, endLine: Int, startColumn: Int, endColumn: Int, parser: MacroConfigFileParser) { |
There was a problem hiding this comment.
Could startLine: Int, endLine: Int, startColumn: Int, endColumn: Int be something like rhs: Range<SourceLocation>?
There was a problem hiding this comment.
I guess yah, maybe in a future PR :)
mirza-garibovic
approved these changes
Jun 4, 2025
|
@swift-ci please test linux |
mirza-garibovic
pushed a commit
to mirza-garibovic/swift-build
that referenced
this pull request
Jul 3, 2025
Originally only one line was tracked here (the end line effectively), but we also have to track the start line separately for correct multi-line ranges. (cherry picked from commit b78e04a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally only one line was tracked here (the end line effectively), but we also have to track the start line separately for correct multi-line ranges.