Update LocalFS to use FileManager for all operations #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveinglis
commented
Jun 6, 2025
|
@swift-ci test |
daveinglis
force-pushed
the
localfs_updates
branch
from
837d965 to
3c1a8aa
Compare
|
@swift-ci test |
Sources/SWBUtil/FSProxy.swift
Outdated
There was a problem hiding this comment.
Can you express this as return fileAttrs[.type] == FileAttributeType.typeRegular to avoid the force cast?
There was a problem hiding this comment.
I get Cannot convert value of type '(any Sendable)?' to expected argument type 'FileAttributeType'
Sources/SWBUtil/FSProxy.swift
Outdated
There was a problem hiding this comment.
Can the value be any Sendable & any Equatable? I think that might allow simplifying:
return NSDictionary(dictionary: lhs.fileAttrs).isEqual(NSDictionary(dictionary: rhs.fileAttrs))to
return lhs.fileAttrs == rhs.fileAttrsThere was a problem hiding this comment.
ya, I have tried this, I get Type 'any Equatable & Sendable' cannot conform to 'Equatable'``. I'm not sure what Im missing...
daveinglis
force-pushed
the
localfs_updates
branch
from
3c1a8aa to
7a522bd
Compare
|
@swift-ci test |
daveinglis
requested review from
aciidgh,
mhrawdon,
mirza-garibovic and
neonichu
as code owners
|
@swift-ci test linux |
|
@swift-ci test |
owenv
approved these changes
Jun 9, 2025
|
@swift-ci test |
jakepetroules
requested changes
Jun 10, 2025
daveinglis
force-pushed
the
localfs_updates
branch
from
7a522bd to
1ee145d
Compare
|
@swift-ci test |
LocalFS was using some posix APIs (stat, mkdir, chmod, chown, etc) with some being used in Windows which mean long filenames would fail in some cases, this cleans that up making all platforms that same
daveinglis
force-pushed
the
localfs_updates
branch
from
1ee145d to
427374a
Compare
|
@swift-ci test |
|
@swift-ci test linux |
|
@swift-ci test linux |
jakepetroules
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalFS was using some posix APIs (stat, mkdir, chmod, chown, etc) with some being used in Windows which mean long filenames would fail in some cases, this cleans that up making all platforms that same