[6.2] WatchKitTests.watchBackDeploymentArtifacts(): Make the check for the build version in arm64/arm64e slices in the WatchKit stub binary more permissive #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhrawdon
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
neonichu and
owenv
as code owners
|
@swift-ci test |
owenv
approved these changes
Jun 11, 2025
jakepetroules
approved these changes
Jun 11, 2025
mhrawdon
changed the title
…build version in arm64/arm64e slices in the WatchKit stub binary more permissive Also tidy up the logic of these checks since they all are implicitly assuming a single build version per arch, and that's also needed to use the >= comparison. rdar://152870849
mhrawdon
force-pushed
the
mhrawdon/watchBackDeploymentArtifacts
branch
from
ae9574f to
0e724ae
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tidy up the logic of these checks since they all are implicitly assuming a single build version per arch, and that's also needed to use the
>=comparison.rdar://152870849