Skip to content

[swift] Get correct ExitStatus if swift tasks receives signal #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

[swift] Get correct ExitStatus if swift tasks receives signal #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/SWBTaskExecution/TaskActions/SwiftDriverJobTaskAction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,14 +469,18 @@ public final class SwiftDriverJobTaskAction: TaskAction, BuildValueValidatingTas
}

func processFinished(result: CommandExtendedResult) {
guard let status = Processes.ExitStatus.init(rawValue: result.exitStatus) else {
// nil means the job is stopped or continued. It should not call finished.
return
}
// This may be updated by commandStarted in the case of certain failures,
// so only update the exit status in output delegate if it is nil.
if outputDelegate.result == nil {
outputDelegate.updateResult(TaskResult(result))
}
self._commandResult = result.result
do {
try plannedBuild?.jobFinished(job: driverJob, arguments: arguments, pid: pid.pid, environment: environment, exitStatus: .exit(result.exitStatus), output: output)
try plannedBuild?.jobFinished(job: driverJob, arguments: arguments, pid: pid.pid, environment: environment, exitStatus: status, output: output)
} catch {
executionError = error.localizedDescription
}
Expand Down
Loading