Add String Catalog symbol generation support to SwiftBuild #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewseaman
requested review from
aciidgh,
jakepetroules,
kulpreetchilana,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
jakepetroules
approved these changes
Jun 12, 2025
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test Windows |
owenv
approved these changes
Jun 21, 2025
dschaefer2
pushed a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jun 25, 2025
… both Sources and Resources (#8815) - **Explanation**: This change adds support for String Catalog symbol generation by ensuring that String Catalogs get added to the Sources build phase in the same way that Asset Catalogs do. Depends on: swiftlang/swift-build#582 - **Scope**: Packages that include String Catalogs. - **Issue**: rdar://147474472 - **Risk**: Change is already tested and in use within Xcode. - **Testing**: Unit tests added here, plus usage within Xcode.
marcprux
pushed a commit
to swift-everywhere/swift-package-manager
that referenced
this pull request
Jul 7, 2025
… both Sources and Resources (swiftlang#8815) - **Explanation**: This change adds support for String Catalog symbol generation by ensuring that String Catalogs get added to the Sources build phase in the same way that Asset Catalogs do. Depends on: swiftlang/swift-build#582 - **Scope**: Packages that include String Catalogs. - **Issue**: rdar://147474472 - **Risk**: Change is already tested and in use within Xcode. - **Testing**: Unit tests added here, plus usage within Xcode.
dschaefer2
pushed a commit
to dschaefer2/swift-package-manager
that referenced
this pull request
Jul 8, 2025
… both Sources and Resources (swiftlang#8815) - **Explanation**: This change adds support for String Catalog symbol generation by ensuring that String Catalogs get added to the Sources build phase in the same way that Asset Catalogs do. Depends on: swiftlang/swift-build#582 - **Scope**: Packages that include String Catalogs. - **Issue**: rdar://147474472 - **Risk**: Change is already tested and in use within Xcode. - **Testing**: Unit tests added here, plus usage within Xcode.
dschaefer2
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Jul 8, 2025
… Catalogs as both Sources and Resources (#8815) (#8905) Support String Catalog symbol generation by adding String Catalogs as both Sources and Resources (#8815) - **Explanation**: This change adds support for String Catalog symbol generation by ensuring that String Catalogs get added to the Sources build phase in the same way that Asset Catalogs do. Depends on: swiftlang/swift-build#582 - **Scope**: Packages that include String Catalogs. Co-authored-by: Matt Seaman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds String Catalog symbol generation support to SwiftBuild.
I will follow-up with a PR to factor out String Catalog (and some Asset Catalog) nuance out of the core build system.