Skip to content

[6.2] Don't crash in tests in CodeGenerationToolTests don't have a compile task, emit a test issue instead. #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

[6.2] Don't crash in tests in CodeGenerationToolTests don't have a compile task, emit a test issue instead. #585

merged 1 commit into from
Jun 20, 2025

Conversation

mhrawdon
Copy link
Contributor

rdar://153135551

@mhrawdon mhrawdon force-pushed the mhrawdon/CodeGenerationToolTests-crash-fix branch from 7f3784f to 5b71021 Compare June 13, 2025 17:42
@mhrawdon
Copy link
Contributor Author

@swift-ci test

@mhrawdon mhrawdon changed the title Don't crash in tests in CodeGenerationToolTests don't have a compile task, emit a test issue instead. [6.2] Don't crash in tests in CodeGenerationToolTests don't have a compile task, emit a test issue instead. Jun 13, 2025
jakepetroules
jakepetroules approved these changes Jun 13, 2025
View reviewed changes
@mhrawdon
Don't crash in tests in CodeGenerationToolTests don't have a compile …
cfa009e 
…task, emit a test issue instead.

rdar://153135551
@mhrawdon mhrawdon force-pushed the mhrawdon/CodeGenerationToolTests-crash-fix branch from 5b71021 to cfa009e Compare June 13, 2025 20:18
@mhrawdon
Copy link
Contributor Author

@swift-ci test

@mhrawdon
Copy link
Contributor Author

@swift-ci test Windows

@mhrawdon
Copy link
Contributor Author

@swift-ci test windows platform

3 similar comments
@mhrawdon
Copy link
Contributor Author

@swift-ci test windows platform

@mhrawdon
Copy link
Contributor Author

@swift-ci test windows platform

@mhrawdon
Copy link
Contributor Author

@swift-ci test windows platform

@mhrawdon
Copy link
Contributor Author

@swift-ci test windows

2 similar comments
@mhrawdon
Copy link
Contributor Author

@swift-ci test windows

@mhrawdon
Copy link
Contributor Author

@swift-ci test windows

@mhrawdon mhrawdon merged commit d397ecd into release/6.2 Jun 20, 2025
163 of 171 checks passed
@mhrawdon mhrawdon deleted the mhrawdon/CodeGenerationToolTests-crash-fix branch June 20, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh aciidgh is a code owner

@mirza-garibovic mirza-garibovic Awaiting requested review from mirza-garibovic mirza-garibovic is a code owner

@neonichu neonichu Awaiting requested review from neonichu neonichu is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhrawdon @jakepetroules