Skip to content

Annotate two tests as flaky #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

Annotate two tests as flaky #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/SWBCoreTests/SettingsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5073,7 +5073,7 @@ import SWBMacro
/// Test that we can look up different `Settings` objects the caching in the `BuildRequestContext` works.
///
/// In particular this checks whether looking up `Settings` with the same parameters and purpose returns the same object each time, and that looking up similar but slightly different `Settings` will not return the wrong one. This way we can test, for example, that changes to the `SettingsCacheKey` work as expected.
@Test
@Test(.flaky("Intermittent failures in Swift CI"))
func settingsCaching() async throws {
let testWorkspace = try await TestWorkspace(
"Workspace",
Expand Down
2 changes: 1 addition & 1 deletion Tests/SWBUtilTests/FileHandleTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import SystemPackage
#endif

@Suite fileprivate struct FileHandleTests {
@Test(.skipHostOS(.freebsd, "Currently crashes on FreeBSD"))
@Test(.flaky("Intermittent failures in Swift CI"), .skipHostOS(.freebsd, "Currently crashes on FreeBSD"))
func asyncReadFileDescriptor() async throws {
let fs = localFS
try await withTemporaryDirectory(fs: fs) { testDataPath in
Expand Down
Loading