Dependencies: validate Swift imports against MODULE_DEPENDENCIES and provide fix-its (rdar://154967562) #641
Conversation
This is mostly declarative right now, but does inform implicit dependencies. (cherry picked from commit 475fde5)
…gs (swiftlang#513) This can be used to emit fix-its for XCConfigs files during the build process. (cherry picked from commit eca9ed5)
In swiftlang#513, initial support for this was added, this PR moves the location to be per assignment which allows emitting fix its not just for the last seen assignments. This will also allow looking at any conditions of assignments when choosing the location for emitting fix its. (cherry picked from commit db41e13)
Originally only one line was tracked here (the end line effectively), but we also have to track the start line separately for correct multi-line ranges. (cherry picked from commit b78e04a)
…ss condition binding (cherry picked from commit 30ec11c)
…provide fix-its (rdar://154967562) (cherry picked from commit 572505d)
mirza-garibovic
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci test |
|
Need swift-driver changes from main into 6.2, following up. |
|
Got swiftlang/swift#82779 and waiting on swiftlang/swift-driver#1950 |
|
@swift-ci test |
|
We're getting the swift-driver changes in the Jenkins CI (not in GH actions), but they're hitting a different issue which I can't reproduce locally: https://ci.swift.org/job/pr-swift-build-macos/1026/
IIUC this implies that the test build proceeded past Swift Driver planning... |
|
@swift-ci test |
|
We decided not to pull this into 6.2. Closing |
5 participants
Cherry-picks macro location tracking, MODULE_DEPENDENCIES, VALIDATE_MODULE_DEPENDENCIES, and Swift import validation.