Handle cross-language duplications for missing dependencies #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic and
owenv
as code owners
|
@swift-ci please test |
|
I'd change this to emit a single top-level diag+fixit which includes both swift and clang sources of module deps, that way you avoid two |
|
@swift-ci please test |
|
@swift-ci test macos |
1 similar comment
|
@swift-ci test macos |
If a missing C dependency is also a dependency of the Swift code in a module, we won't report the dependency as missing from the C context.
Instead of emitting diagnostics separately per language, this emits them together by first computing missing dependencies for each language and then merging and deduplicating them before diagnostic generation. The code here will be forward compatible when we extend the Clang implementation to respect access levels and/or provide import locations.
neonichu
force-pushed
the
module-deps-cross-language
branch
from
837897c to
49075cb
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
owenv
approved these changes
Aug 1, 2025
Sources/SWBTaskExecution/TaskActions/ValidateDependenciesTaskAction.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of emitting diagnostics separately per language, this emits them together by first computing missing dependencies for each language and then merging and deduplicating them before diagnostic generation.
The code here will be forward compatible when we extend the Clang implementation to respect access levels and/or provide import locations.