Export EFFECTIVE_SWIFT_VERSION in the environment to shell script build phases. #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld phases. rdar://158424030
mhrawdon
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
neonichu and
owenv
as code owners
|
@swift-ci test |
|
test? |
neonichu
approved these changes
Aug 18, 2025
|
Jake: If you're asking about a test for this change, we don't have a test or suite of tests checking what values are exported to script phases. We'd probably need to figure out what policy we want to employ for such a test (probably we don't want to check every single setting, but if not, then what?) and doing so is beyond the scope of this change. (Historically we have never added tests like this small improvements to a much larger system such as this.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://158424030