Skip to content

Dependencies: validate unused module dependencies #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2025
Merged

Dependencies: validate unused module dependencies #744

merged 2 commits into from
Aug 29, 2025

Conversation

mirza-garibovic
Copy link
Contributor

@mirza-garibovic mirza-garibovic commented Aug 20, 2025 •
edited by bob-wilson
Loading

rdar://159126103

@mirza-garibovic
Copy link
Contributor Author

@swift-ci test

@mirza-garibovic
Copy link
Contributor Author

I'm going to expand this PR to also allow for optional dependencies.

@mirza-garibovic
Copy link
Contributor Author

@swift-ci test

bob-wilson
bob-wilson reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@bob-wilson bob-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me, but it seems like we're piling up a lot of separate settings to control the diagnostics. At some point, we need to figure out a plan to simplify that, e.g., with some overarching setting that sets the defaults for different things.

@mirza-garibovic
Copy link
Contributor Author

This looks OK to me, but it seems like we're piling up a lot of separate settings to control the diagnostics. At some point, we need to figure out a plan to simplify that, e.g., with some overarching setting that sets the defaults for different things.

Yeah, I agree. I think we're thinking of the fine-grained settings as temporary for initial rollout and user testing, to avoid having a universal setting like VALIDATE_DEPENDENCIES / VALIDATE_UNUSED_DEPENDENCIES rapidly change behavior.

@mirza-garibovic
Copy link
Contributor Author

@swift-ci test

@mirza-garibovic
Copy link
Contributor Author

Tests aren't running... @swift-ci test

@mirza-garibovic
Copy link
Contributor Author

@swift-ci test

@mirza-garibovic mirza-garibovic merged commit e6e8487 into swiftlang:main Aug 29, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bob-wilson bob-wilson bob-wilson left review comments

@neonichu neonichu neonichu approved these changes

@jakepetroules jakepetroules jakepetroules approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh aciidgh is a code owner

@mhrawdon mhrawdon Awaiting requested review from mhrawdon mhrawdon is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mirza-garibovic @neonichu @jakepetroules @bob-wilson