Add a facility for tests to opt in to loading the downloadable Metal toolchain #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toolchain This will greatly reduce the number of tests which fail when there is a problem with the downloadable Metal toolchain. This is off by default, since very few tests need this. Two tests currently opt in.
mhrawdon
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
neonichu and
owenv
as code owners
|
@swift-ci test |
neonichu
approved these changes
Aug 21, 2025
| let toolchainSearchPath: String | ||
| } | ||
|
|
||
| let result = try await Process.getOutput(url: URL(fileURLWithPath: activeDeveloperPath.join("usr/bin/xcodebuild").str), arguments: ["-showComponent", "metalToolchain", "-json"], environment: ["DEVELOPER_DIR": activeDeveloperPath.str]) |
There was a problem hiding this comment.
This should use runProcess instead, since it already wraps getOutput with the necessary plumbing to emit a good error message if the command fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will greatly reduce the number of tests which fail when there is a problem with the downloadable Metal toolchain.
This is off by default, since very few tests need this. Two tests currently opt in.