Skip to content

Do not guard check for duplicate message names behind DEBUG compilation condition #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

Do not guard check for duplicate message names behind DEBUG compilation condition #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions Sources/SWBProtocol/Message.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,16 +1222,10 @@ public struct IPCMessage: Serializable, Sendable {
/// Reverse name mapping.
static let messageNameToID: [String: any Message.Type] = {
var result = [String: any Message.Type]()
#if DEBUG
var seenMessageNames: Set<String> = []
for messageType in messageTypes {
if !seenMessageNames.insert(messageType.name).inserted {
assertionFailure("Multiple message types registered for same name: \(messageType.name)")
}
}
#endif
for type in IPCMessage.messageTypes {
result[type.name] = type
if let oldValue = result.updateValue(type, forKey: type.name) {
fatalError("Multiple message types registered for same name: \(type.name): \(type) vs \(oldValue)")
}
}
return result
}()
Expand Down