Properly quote linker file list contents on Linux and Windows #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic and
neonichu
as code owners
|
@swift-ci test |
|
This really needs to depend on the specific linker in use; what about cross compilation scenarios where we are using lld on macOS or Windows? |
owenv
force-pushed
the
linker-quoting
branch
from
9518f52 to
139f41e
Compare
The general idea here is that this change establishes the correct platform-default behavior, and then we'll need to inspect -fuse-ld flags at some point to override that behavior when manually selecting a different linker |
|
@swift-ci test |
owenv
force-pushed
the
linker-quoting
branch
from
139f41e to
33c3975
Compare
|
@swift-ci test |
| private static let dollarSign = Character("$") | ||
| } | ||
|
|
||
| /// Suitable for escaping Windows process arguments, but NOT command lines which will be interpreted by a shell |
There was a problem hiding this comment.
Excellent call out :)
jakepetroules
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.