Fixup StackedSearchPathLookupError error message #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target file that could not be found was printing `Path(_str: "libclang.so")` instead of `libclang.so`. Add the `.str` to the `Path` so just the filename is printed.
plemarquand
requested review from
aciidgh,
jakepetroules,
mhrawdon,
mirza-garibovic,
neonichu and
owenv
as code owners
bkhouri
approved these changes
Sep 5, 2025
bkhouri
reviewed
Sep 5, 2025
| case let .unableToFind(subject, operatingSystem, searchPaths): | ||
| let candidates = searchPaths.flatMap { $0.paths.map { $0.join(subject.fileName(operatingSystem: operatingSystem)).str }} | ||
| return "unable to find \(subject.fileName(operatingSystem: operatingSystem)) among search paths: \(candidates.joined(separator: ", "))" | ||
| return "unable to find \(subject.fileName(operatingSystem: operatingSystem).str) among search paths: \(candidates.joined(separator: ", "))" |
There was a problem hiding this comment.
suggestion: could we add a small test to ensure we don't regress here?
There was a problem hiding this comment.
I don't know if it's worth it because the string form of error messages is not considered stable -- if we changed it again we'd just change the test here too and break downstream anyways.
owenv
approved these changes
Sep 5, 2025
|
@swift-ci test |
jakepetroules
approved these changes
Sep 5, 2025
| case let .unableToFind(subject, operatingSystem, searchPaths): | ||
| let candidates = searchPaths.flatMap { $0.paths.map { $0.join(subject.fileName(operatingSystem: operatingSystem)).str }} | ||
| return "unable to find \(subject.fileName(operatingSystem: operatingSystem)) among search paths: \(candidates.joined(separator: ", "))" | ||
| return "unable to find \(subject.fileName(operatingSystem: operatingSystem).str) among search paths: \(candidates.joined(separator: ", "))" |
There was a problem hiding this comment.
I don't know if it's worth it because the string form of error messages is not considered stable -- if we changed it again we'd just change the test here too and break downstream anyways.
plemarquand
deleted the
fixup-stacked-search-paths-lookup-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target file that could not be found was printing
Path(_str: "libclang.so")instead oflibclang.so.Add the
.strto thePathso just the filename is printed.