Pass -Xcc -std=c++2b to Swift when CLANG_CXX_LANGUAGE_STANDARD is set to c++2b
#837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set to `c++2b` If pbxproj contains this line: ``` CLANG_CXX_LANGUAGE_STANDARD = "c++2b"; ``` then we should pass the corresponding flag to Swift compiler invocations that enable Swift/C++ interop. Prior to this change, this worked fine for `c++23`, but not `c++2b`. rdar://149474443
egorzhdan
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci please test |
owenv
approved these changes
Oct 2, 2025
neonichu
approved these changes
Oct 2, 2025
jakepetroules
approved these changes
Oct 2, 2025
|
The sole test failure on the CI doesn't seem to be caused by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pbxproj contains this line:
then we should pass the corresponding flag to Swift compiler invocations that enable Swift/C++ interop.
Prior to this change, this worked fine for
c++23, but notc++2b.rdar://149474443