Retain old-syle response file escaping on macOS for compatibility #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
aciidgh,
jakepetroules,
mhrawdon and
neonichu
as code owners
|
@swift-ci test |
mhrawdon
approved these changes
Oct 6, 2025
neonichu
approved these changes
Oct 6, 2025
|
Wouldn't these projects have failed if response files were turned off entirely? Since arguments are used exactly as the macro system sees their resolved value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects on macOS currently manually shell escape the values of build settings which are translated to compiler args, which breaks the escaping change here, as they end up double escaped. Restore the old behavior on macOS for compatibility.
rdar://162035972