Skip to content

Fix building .S files on windows & resource bundles #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

Fix building .S files on windows & resource bundles #853

merged 1 commit into from
Oct 8, 2025

Conversation

daveinglis
Copy link
Contributor

  • building .S files on windows requires clang to have TMP/TEMP env passed (also move the linker change that added TMPDIR to the tool env to the spec file for consistency).
  • fix the resource bundle error that when touching a file was passing a badly quoted path.

@daveinglis daveinglis force-pushed the window_fixes branch 2 times, most recently from ac3ac9e to 6e6f403 Compare October 8, 2025 14:45
@daveinglis
Copy link
Contributor Author

@swift-ci test

@owenv
Copy link
Collaborator

owenv commented Oct 8, 2025 

[2025-10-08T15:38:31.837Z] × Test touchTaskConstruction() recorded an issue at CommandLineSpecTests.swift:1723:34: Expectation failed: (actual → ["C:\\Windows\\system32\\cmd.exe", "/c", "copy", "/b", "C:\\tmp\\input", "+,,"]) == (expected → ["C:\\Windows\\system32\\cmd.exe", "/c", "copy /b \"C:\\tmp\\input\" +,,"])

Looks like the test just needs a small fixup

@daveinglis
Fix building .S files on windows & resource bundles
643b268 
- building .S files on windows requires clang to have TMP/TEMP env
  passed (also move the linker change that added TMPDIR to the tool
  env to the spec file for consistency).

- fix the resource bundle error that when touching a file was
  passing a badly quoted path.
@daveinglis
Copy link
Contributor Author

@swift-ci test

jakepetroules
jakepetroules approved these changes Oct 8, 2025
View reviewed changes
@daveinglis
Copy link
Contributor Author

@swift-ci test

@daveinglis daveinglis merged commit 320e518 into swiftlang:main Oct 8, 2025
44 of 47 checks passed
@daveinglis daveinglis mentioned this pull request Oct 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@jakepetroules jakepetroules jakepetroules approved these changes

@owenv owenv owenv approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh aciidgh is a code owner

@mhrawdon mhrawdon Awaiting requested review from mhrawdon mhrawdon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daveinglis @owenv @neonichu @jakepetroules