Reduce traffic through macroConfigPaths lock
#860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
aciidgh,
jakepetroules,
mhrawdon and
owenv
as code owners
Collaborator
Author
|
@swift-ci please test |
Collaborator
Author
|
Need to test whether this actually fixes the observed performance issues, but from code inspection this seems to be the primary culprit of going through the lock and also easily remedied. |
owenv
approved these changes
Oct 20, 2025
Internally to `MacroValueAssignmentTable` we were looking up interned location references to paths and back, even though we really only need to pass the reference to new `MacroValueAssignment` instances. rdar://146340881
neonichu
force-pushed
the
bbuegling/reduce-macroConfigPaths-lock-traffic
branch
from
ded0c11 to
2cc96ff
Compare
Collaborator
Author
|
@swift-ci please test |
Collaborator
Author
|
I haven't gotten to fully reproducing the reported perf issues, but I think it makes sense to merge this PR regardless. The changes should be correct and would reduce the call sites that require this lock significantly, so there's no need to hold the PR back on the determination whether that fully fixes the issue. I'll separately reproduce and open follow-up PRs if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally to
MacroValueAssignmentTablewe were looking up interned location references to paths and back, even though we really only need to pass the reference to newMacroValueAssignmentinstances.rdar://146340881