add build settings to build properly on linux#39
Open
QuietMisdreavus wants to merge 2 commits intogfmfrom
Open
add build settings to build properly on linux#39QuietMisdreavus wants to merge 2 commits intogfmfrom
QuietMisdreavus wants to merge 2 commits intogfmfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with
swift buildon Linux, theapi_testtarget will fail to build for two reasons:pthreadscmark_gfmmodule is not labeled asextern_c, and it causes an error when being imported in the C++ testsThis PR fixes those two issues.