Skip to content

Commit 7a24ee9

Browse files
authored
Add padding between nav and filter in S/M Viewport (#808) rdar://124561315
Add padding between nav and filter in S/M Viewport (#808) rdar://124561315
1 parent 15d7887 commit 7a24ee9

File tree

7 files changed

+13
-11
lines changed

7 files changed

+13
-11
lines changed

src/components/DocumentationTopic/DocumentationNav/LanguageToggle.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ $nav-menu-toggle-label-margin: 6px;
316316
display: inline-block;
317317
318318
&:not(:first-child) {
319-
border-left: 1px solid var(--color-grid);
319+
border-left: $generic-border-style;
320320
margin-left: $nav-menu-toggle-label-margin;
321321
padding-left: $nav-menu-toggle-label-margin;
322322
}

src/components/Footer.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default {
3030
@import 'docc-render/styles/_core.scss';
3131
3232
.footer {
33-
border-top: 1px solid var(--color-grid);
33+
border-top: $generic-border-style;
3434
}
3535
3636
.row {

src/components/Navigator/NavigatorCard.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -977,7 +977,7 @@ export default {
977977
978978
// unfortunately we need to hard-code the filter height
979979
$filter-height: 71px;
980-
$filter-height-small: 50px;
980+
$filter-height-small: 60px;
981981
$close-icon-size: 19px;
982982
$technology-title-background: var(--color-fill) !default;
983983
$technology-title-background-active: var(--color-fill-gray-quaternary) !default;
@@ -1044,7 +1044,7 @@ $navigator-card-vertical-spacing: 8px !default;
10441044
.navigator-filter {
10451045
box-sizing: border-box;
10461046
padding: 15px var(--nav-filter-horizontal-padding);
1047-
border-top: 1px solid var(--color-grid);
1047+
border-top: $generic-border-style;
10481048
height: $filter-height;
10491049
display: flex;
10501050
align-items: flex-end;
@@ -1060,7 +1060,7 @@ $navigator-card-vertical-spacing: 8px !default;
10601060
@include breakpoint(medium, nav) {
10611061
--nav-filter-horizontal-padding: 20px;
10621062
border: none;
1063-
padding-top: 0px;
1063+
padding-top: 10px;
10641064
padding-bottom: 10px;
10651065
height: $filter-height-small;
10661066
}

src/components/Navigator/QuickNavigationButton.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default { name: 'QuickNavigationButton' };
3030
align-items: center;
3131
justify-content: center;
3232
width: $icon-size-default;
33-
border: 1px solid var(--color-grid);
33+
border: $generic-border-style;
3434
height: 100%;
3535
border-radius: $small-border-radius;
3636
transition: background-color .15s;

src/components/SuggestLang.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ $banner-icon-padding: $nav-padding-small * 0.25;
8282
color: light-color(fill);
8383
display: flex;
8484
justify-content: center;
85-
border-bottom: 1px solid var(--color-grid);
85+
border-bottom: $generic-border-style;
8686
8787
&__wrapper {
8888
display: flex;

src/styles/core/_vars.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ $globalnav-height: 44px;
1313

1414
$form-focus-size: 4px;
1515

16+
$generic-border-style: 1px solid var(--color-grid);
17+
1618
// Border radius
1719
$border-radius: var(--border-radius, 4px) !default;
1820
$nano-border-radius: $border-radius !default;

src/views/DocumentationTopic.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -469,14 +469,14 @@ export default {
469469
.doc-topic-aside {
470470
height: 100%;
471471
box-sizing: border-box;
472-
border-right: 1px solid var(--color-grid);
472+
border-right: $generic-border-style;
473473
474474
@include breakpoint(medium, nav) {
475475
background: var(--color-fill);
476476
border-right: none;
477477
478478
.sidebar-transitioning & {
479-
border-right: 1px solid var(--color-grid);
479+
border-right: $generic-border-style;
480480
}
481481
}
482482
}
@@ -494,8 +494,8 @@ export default {
494494
@include inTargetWeb {
495495
@include breakpoint-full-width-container();
496496
@include breakpoints-from(xlarge) {
497-
border-left: 1px solid var(--color-grid);
498-
border-right: 1px solid var(--color-grid);
497+
border-left: $generic-border-style;
498+
border-right: $generic-border-style;
499499
box-sizing: border-box;
500500
}
501501
}

0 commit comments

Comments
 (0)