[5.6] Cherry pick "Split Symbol.swift to reduce complexity of the file" #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate into 2 commits because git can't mark it as rename since the change is too big
|
cc @sara-radi, who is the interim 5.6 branch manager while @franklinsch is on vacation. This looks like it's porting the whole of |
sara-radi
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Symbol.swift currently has 1400 lines.
This PR is intended to split the Symbol.swift file into a file system hierarchy.
So that the Symbol.swift only have SymbolGraph.Symbol definition and also makes it easier for writing test case.
Since the other 2 diff commit only changed the docs, I think they are low-risk too.
@ethan-kusters Could you please help confirm this?