Revert "Revert "[5.7] add ivar and macro to known symbol kinds""
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit b99e3e1.
|
@swift-ci Please test |
|
@QuietMisdreavus Did we run a toolchain build to ensure that this change + DocC build together? |
|
@franklinsch I'm building that right now, and should be able to test by the end of the day. |
ethan-kusters
approved these changes
Apr 21, 2022
|
@franklinsch I was able to build a toolchain with this change and swiftlang/swift-docc#152, and it was properly able to surface and organize instance variables and macros. |
franklinsch
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #25
This PR re-introduces #23, now that changes have landed in Swift-DocC (swiftlang/swift-docc#133) to allow it to land without breaking the build. The original PR's release information follows.
Explanation: In preparation of allowing SymbolKit (and by proxy, Swift-DocC) to accept symbol graphs from Clang, this PR adds two new symbol kinds to the
KindIdentifierenum:ivar(for Objective-C instance variables) andmacro(for C preprocessor macros).Scope: A low-impact change that shouldn't affect any existing uses of SymbolKit/Swift-DocC, and enables new ones.
Radar: rdar://91166981
Risk: Low. New
KindIdentifiercases will not cause any existing workflows that use SymbolKit to change or be affected.Testing: A new automated test has been added to ensure that symbol kinds can be parsed as themselves when serialized out and re-read. All existing automated tests still pass.