Remove redundant "bundle" parameters where a context is also available

[d-ronnqvist]

Bug/issue #, if applicable:

Summary

Now that DocumentationContext is known have exactly one inputs/bundle, types and methods don't need both a context parameter and a inputs/bundle parameter.

This PR goes through various types one-by-one and removes the bundle parameters and updates all the callers to stop passing it.

The main benefit of this is that it's no longer possible to pass a bundle/inputs that don't belong to the context.

Another outcome of this is that many tests who call the context loading test helpers now ignore the bundle. A follow up PR, after this is merged, will clean up the test helpers and have the caller access the bundle/inputs from the context where needed.

Dependencies

None.

Testing

Nothing in particular. This isn't a user-facing change.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

• Added tests
• Ran the ./bin/test script and it succeeded
• [ ] Updated documentation if necessary

[d-ronnqvist]

@swift-ci please test

[d-ronnqvist]

@swift-ci please test

[d-ronnqvist]

@swift-ci please test

[d-ronnqvist]

@swift-ci please test

[patshaughnessy]

Looks good to me.

Question: Is there a longer term plan to remove DocumentationBundle entirely? Here you remove passing the bundle into many call sites, but we still have other places that reference DocumentationBundle itself.

[patshaughnessy]

This is new Swift syntax for me - does this destructure renderer and documentationContext from the reference value passed into the closure? Why isn't this written the other way around? Like this:

... = { reference [renderer, documentationContext]  in

[d-ronnqvist]

The variables within angle brackets is a Swift closure is a "capture list".

The same way that the previous code was shadowing renderer and documentationContext with local variables to avoid strongly capturing self in the closure, the capture list captures renderer and documentationContext explicitly as their own variables instead of them referring to self.renderer and self.documentationContext which would capture self.

[patshaughnessy]

Why isn't this needed any more? testBundleAndContext no longer creates an actual bundle/file?

[d-ronnqvist]

It hasn't been needed since somewhere 2021/2022 because testBundleAndContext(copying:...) already clears up any temporary files that it creates.

[patshaughnessy]

Suggested change

	let bundle = context.inputs
	let inputs = context.inputs

Why not rename the local variable to match? And throughout the PR I see you retain the identifier bundle aren't we trying to move away from using bundle?

[d-ronnqvist]

I did most of the renaming using IDE renaming actions which doesn't catch locally scoped variables. I can remove this one variable since I need to rebase the PR anyway.

[d-ronnqvist]

I found another similarly named variable and updated both in e1c04b7

[d-ronnqvist]

@swift-ci please test

[d-ronnqvist]

Is there a longer term plan to remove DocumentationBundle entirely? Here you remove passing the bundle into many call sites, but we still have other places that reference DocumentationBundle itself.

Not to remove it completely but to rename it to better reflect the information that it represents (a collection of input files for the context). There is already a package access typealias for this; DocumentationContext.Inputs. There is still value having some abstraction that groups together input files from different sources so that the context doesn't need to know all the details around where those inputs files come from.