Skip to content

Conversation

@marinaaisa
Copy link
Member

@marinaaisa marinaaisa commented Jul 25, 2025

We need to update the Node version to 22.17.0 in the Swift CI for Docc-Render, to ensure compatibility with the updated Node version used in the project.

It fixes: rdar://156708326

@marinaaisa marinaaisa requested a review from shahmishal as a code owner July 25, 2025 15:56
We need to update the Node version to 22.17.0 in the Swift CI for
Docc-Render, to ensure compatibility with the updated Node version used
in the project. [1]

[1] swiftlang/swift-docc-render#952
@marinaaisa marinaaisa force-pushed the update-node-swift-docc-render branch from b59d4ce to 0f59dd5 Compare July 25, 2025 15:58
@heckj
Copy link
Member

heckj commented Jul 25, 2025

When I ran this manually to see what the issue was, I found:

 swift-docker git:(update-node-swift-docc-render) docker build --no-cache=true -f swift-ci/swift-docc-render/Dockerfile -t swift_ci_swift_docc_render_dockerfile .
[+] Building 11.5s (9/10)
 => [internal] load build definition from Dockerfile                                                               0.0s
 => => transferring dockerfile: 543B                                                                               0.0s
 => [internal] load metadata for docker.io/library/node:22.17.0                                                    5.3s
 => [internal] load .dockerignore                                                                                  0.0s
 => => transferring context: 2B                                                                                    0.0s
 => [1/7] FROM docker.io/library/node:22.17.0@sha256:2fa6c977460b56d4d8278947ab56faeb312bc4cc6c4cf78920c6de27812f  4.3s
 => => resolve docker.io/library/node:22.17.0@sha256:2fa6c977460b56d4d8278947ab56faeb312bc4cc6c4cf78920c6de27812f  0.0s
 => => sha256:702056b1e41d7626a33f063ed639d92a920df1f45cdf0297e012ef6e10553f79 6.64kB / 6.64kB                     0.0s
 => => sha256:436c969d6f21c894a817e250f2c315c8b5cf92e2b9440ddb568d2261cc816bad 3.33kB / 3.33kB                     1.5s
 => => sha256:78e6350e60037ab8aa6e5b6371a82a2cb83d3c37ae1888b57084968cb043b209 56.11MB / 56.11MB                   3.0s
 => => sha256:1c89df3395f01d4bca9a5e3ed78e881c8622601a478dc0de3416cf425cd0ddc0 1.25MB / 1.25MB                     3.0s
 => => sha256:2fa6c977460b56d4d8278947ab56faeb312bc4cc6c4cf78920c6de27812f51c5 6.41kB / 6.41kB                     0.0s
 => => sha256:5fbac7b1918173e967ae0094e2169e07e7c15bee7676353effea4bd011303f78 2.50kB / 2.50kB                     0.0s
 => => extracting sha256:436c969d6f21c894a817e250f2c315c8b5cf92e2b9440ddb568d2261cc816bad                          0.0s
 => => sha256:087a9944841baa058d731200a5618255056d20e2d6147d8ee45aa48ace61f21e 447B / 447B                         2.7s
 => => extracting sha256:78e6350e60037ab8aa6e5b6371a82a2cb83d3c37ae1888b57084968cb043b209                          1.1s
 => => extracting sha256:1c89df3395f01d4bca9a5e3ed78e881c8622601a478dc0de3416cf425cd0ddc0                          0.0s
 => => extracting sha256:087a9944841baa058d731200a5618255056d20e2d6147d8ee45aa48ace61f21e                          0.0s
 => [2/7] RUN groupadd -g 998 build-user &&     useradd -m -r -u 998 -g build-user build-user                      0.5s
 => [3/7] WORKDIR /home/build-user                                                                                 0.0s
 => [4/7] RUN git clone https://github.com/apple/swift-docc-render.git                                             1.1s
 => [5/7] RUN cd swift-docc-render && git checkout main                                                            0.1s
 => ERROR [6/7] RUN /home/build-user/swift-docc-render/build-script-helper.py build --verbose                      0.2s
------
 > [6/7] RUN /home/build-user/swift-docc-render/build-script-helper.py build --verbose:
#0 0.139 /usr/bin/env: 'python': No such file or directory
------
Dockerfile:14
--------------------
  12 |     RUN git clone https://github.com/apple/swift-docc-render.git
  13 |     RUN cd swift-docc-render && git checkout $SWIFT_DOCC_RENDER_BRANCH
  14 | >>> RUN /home/build-user/swift-docc-render/build-script-helper.py build --verbose
  15 |     RUN /home/build-user/swift-docc-render/build-script-helper.py test --verbose
  16 |
--------------------
ERROR: failed to solve: process "/bin/sh -c /home/build-user/swift-docc-render/build-script-helper.py build --verbose" did not complete successfully: exit code: 127

It looks like the node:22.17.0 doesn't include python, but does have python3 installed. You could add in a python2 package perhaps, but I suspect it may be better to update build-script-helper.py in Docc-Render from to explicitly use python3

@shahmishal
Copy link
Member

The logs are attached to the action:

Artifact download URL: https://github.com/swiftlang/swift-docker/actions/runs/16526268553/artifacts/3616738078

marinaaisa added a commit to marinaaisa/swift-docc-render that referenced this pull request Jul 28, 2025
By aiming to update the Node version to 22.17.0 on Swift Docker for
Swift DocC Render [1], we need to specify the version 3 of python, otherwise
it will try to use python 2 which it's not available in Node 22.

[1] swiftlang/swift-docker#487
marinaaisa added a commit to marinaaisa/swift-docc-render that referenced this pull request Sep 16, 2025
By aiming to update the Node version to 22.17.0 on Swift Docker for
Swift DocC Render [1], we need to specify the version 3 of python, otherwise
it will try to use python 2 which it's not available in Node 22.

[1] swiftlang/swift-docker#487
marinaaisa added a commit to marinaaisa/swift-docc-render that referenced this pull request Sep 16, 2025
By aiming to update the Node version to 22.17.0 on Swift Docker for
Swift DocC Render [1], we need to specify the version 3 of python, otherwise
it will try to use python 2 which it's not available in Node 22.

[1] swiftlang/swift-docker#487
mportiz08 pushed a commit to swiftlang/swift-docc-render that referenced this pull request Sep 16, 2025
By aiming to update the Node version to 22.17.0 on Swift Docker for
Swift DocC Render [1], we need to specify the version 3 of python, otherwise
it will try to use python 2 which it's not available in Node 22.

Resolves: rdar://156708326

[1] swiftlang/swift-docker#487
@mportiz08
Copy link

@swift-ci test

shahmishal pushed a commit to swiftlang/swift-docc-render that referenced this pull request Sep 16, 2025
* Update Node.js & NPM in project's engines

This change updates Node.js to 22.17.0 & NPM to 10.9.2. I chose 22.17.0
version of Node because it's the latest LTS (Long Term Support) version.

* Update @vue/test-utils

* Update tree-sitter-vue

* Fix LanguageSwitcher.spec.js

* Fix Column.spec.js

* Fix Hero.spec.js

* Fix ColorSchemeToggle.spec.js

* Fix ImageAsset.spec.js

* Fix Pager.spec.js

* Fix Assessments.spec.js

* Fix swift.spec.js

Since highlight.js 11.6+, the `distributed` keyword is built-in and no
custom overrides are needed

* Fix FilterInput.spec.js

* Replace wrapper.find

Replace wrapper.find with wrapper.findComponent instead since
wrapper.find is deprecated

* Wait for wrapper.setProps

* Wait for wrapper.setData

* Await after .trigger() function

* Fix Navigator.spec.js

* Fix ReplayableVideoAsset.spec.js

* Replace 'Contains'

contains is deprecated and will be removed in the next major version.
Use `wrapper.find`, `wrapper.findComponent` or `wrapper.get` instead

* Wait for nextTick after emitting an event

* Fix TopicsLinkCardGridItem.spec.js

* Fix components/DocumentationTopic.spec.js

* Fix Chapter.spec.js

* Fix AdjustableSidebarWidth.spec.js

* Fix Availability.spec.js

* Fix Hierarchy.spec.js

* Fix NavBase.spec.js

* Fix DocumentationLayout.spec.js

* Fix TopicsLinkBlock.spec.js

* Fix CodePreview.spec.js

* Fix  App.spec.js

* Fix DropdownCustom.spec.js

* Wait for .setValue()

* Fix GenericModal.spec.js

* Fix LinksBlock.spec.js

* Fix ResourcesTile.spec.js

* Fix RelationshipsList.spec.js

* Fix all deprecated .is() method warnings

* Fix .find() and .get() deprecation warnings

* Fix .findAll() deprecation warnings

* Fix .contains() deprecation warnings

* Fix .isEmpty() deprecation warnings

* Fix attachToDocument deprecation warnings

* Fix QuickNavigationModal.spec.js

* Fix console error warnings for TopicsLinkBlock.spec.js

* Fix ResourcesTileGroup.spec.js

This change fixes the deprecation warning:

[Vue warn]: Duplicate keys detected: 'A'. This may cause an update
error.

* Fix DeclarationTokenGroup.spec.js

* Remove redundant nextTick

* Update tree-sitter-javascript and tree-sitter-jsdoc

* Make build-script-helper.py use python3

By aiming to update the Node version to 22.17.0 on Swift Docker for
Swift DocC Render [1], we need to specify the version 3 of python, otherwise
it will try to use python 2 which it's not available in Node 22.

[1] swiftlang/swift-docker#487

* Update build-script helper.

---------

Co-authored-by: Marcus Ortiz <[email protected]>
@shahmishal shahmishal merged commit 2b8f410 into swiftlang:main Sep 16, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants