Skip to content

Update Windows Dockerfile to exit on verification of vs_buildtools.exe #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2025
Merged

Update Windows Dockerfile to exit on verification of vs_buildtools.exe #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecb5f86
Update Windows Dockerfile to exit on verification of vs_buildtools.exe
shahmishal Aug 6, 2025
f36fce8
Update the SHA for vs_buildtools to 95B8BCAC49757DBA2BD80827484E65B2F…
shahmishal Aug 6, 2025
422e703
Fix the exit 1 issue with vs_buildtools.exe
shahmishal Aug 6, 2025
9cc2b22
Update the vs_BuildTools.exe version/SHA
shahmishal Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 5.10/windows/1809/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
1 change: 1 addition & 0 deletions 5.10/windows/LTSC2022/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
1 change: 1 addition & 0 deletions 5.9/windows/LTSC2022/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
1 change: 1 addition & 0 deletions 6.0/windows/1809/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
1 change: 1 addition & 0 deletions 6.0/windows/LTSC2022/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
1 change: 1 addition & 0 deletions 6.1/windows/1809/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
1 change: 1 addition & 0 deletions 6.1/windows/LTSC2022/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
5 changes: 3 additions & 2 deletions nightly-6.0/windows/1809/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*

# Install Visual Studio Build Tools
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
ARG VSB_SHA256=15A2A6591B1E91B63E9909864FCBC68459EB26124B814618947215F754CD9CEE
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
ARG VSB_SHA256=A783199025439D65F310BFF041E278B966A6DBED8DBCD7FC96B55389F574EF41
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
Write-Host '✓'; \
Expand All @@ -106,6 +106,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
5 changes: 3 additions & 2 deletions nightly-6.0/windows/LTSC2022/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*

# Install Visual Studio Build Tools
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
ARG VSB_SHA256=15A2A6591B1E91B63E9909864FCBC68459EB26124B814618947215F754CD9CEE
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
ARG VSB_SHA256=A783199025439D65F310BFF041E278B966A6DBED8DBCD7FC96B55389F574EF41
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
Write-Host '✓'; \
Expand All @@ -106,6 +106,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
5 changes: 3 additions & 2 deletions nightly-6.1/windows/1809/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*

# Install Visual Studio Build Tools
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
ARG VSB_SHA256=15A2A6591B1E91B63E9909864FCBC68459EB26124B814618947215F754CD9CEE
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
ARG VSB_SHA256=A783199025439D65F310BFF041E278B966A6DBED8DBCD7FC96B55389F574EF41
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
Write-Host '✓'; \
Expand All @@ -106,6 +106,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
5 changes: 3 additions & 2 deletions nightly-6.1/windows/LTSC2022/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*

# Install Visual Studio Build Tools
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
ARG VSB_SHA256=15A2A6591B1E91B63E9909864FCBC68459EB26124B814618947215F754CD9CEE
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
ARG VSB_SHA256=A783199025439D65F310BFF041E278B966A6DBED8DBCD7FC96B55389F574EF41
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
Write-Host '✓'; \
Expand All @@ -106,6 +106,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
5 changes: 3 additions & 2 deletions nightly-6.2/windows/1809/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*

# Install Visual Studio Build Tools
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
ARG VSB_SHA256=15A2A6591B1E91B63E9909864FCBC68459EB26124B814618947215F754CD9CEE
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
ARG VSB_SHA256=A783199025439D65F310BFF041E278B966A6DBED8DBCD7FC96B55389F574EF41
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
Write-Host '✓'; \
Expand All @@ -106,6 +106,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
5 changes: 3 additions & 2 deletions nightly-6.2/windows/LTSC2022/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*

# Install Visual Studio Build Tools
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
ARG VSB_SHA256=15A2A6591B1E91B63E9909864FCBC68459EB26124B814618947215F754CD9CEE
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
ARG VSB_SHA256=A783199025439D65F310BFF041E278B966A6DBED8DBCD7FC96B55389F574EF41
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
Write-Host '✓'; \
Expand All @@ -106,6 +106,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
5 changes: 3 additions & 2 deletions nightly-main/windows/1809/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*

# Install Visual Studio Build Tools
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
ARG VSB_SHA256=15A2A6591B1E91B63E9909864FCBC68459EB26124B814618947215F754CD9CEE
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
ARG VSB_SHA256=A783199025439D65F310BFF041E278B966A6DBED8DBCD7FC96B55389F574EF41
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
Write-Host '✓'; \
Expand All @@ -106,6 +106,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
5 changes: 3 additions & 2 deletions nightly-main/windows/LTSC2022/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*

# Install Visual Studio Build Tools
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
ARG VSB_SHA256=15A2A6591B1E91B63E9909864FCBC68459EB26124B814618947215F754CD9CEE
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
ARG VSB_SHA256=95B8BCAC49757DBA2BD80827484E65B2F0EF57C11C143B87514B913839F78657
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
Write-Host '✓'; \
Expand All @@ -106,6 +106,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
5 changes: 3 additions & 2 deletions swift-ci/main/windows/LTSC2022/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*

# Install Visual Studio Build Tools
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
ARG VSB_SHA256=C792BDB0FD46155DE19955269CAC85D52C4C63C23DB2CF43D96B9390146F9390
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/ae7ac791-9759-4076-bba7-47ff510c57af/a783199025439d65f310bff041e278b966a6dbed8dbcd7fc96b55389f574ef41/vs_BuildTools.exe
ARG VSB_SHA256=A783199025439D65F310BFF041E278B966A6DBED8DBCD7FC96B55389F574EF41
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
Write-Host '✓'; \
Expand All @@ -139,6 +139,7 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB});
Write-Host '✓'; \
} else { \
Write-Host ('✘ ({0})' -f $Hash.Hash); \
exit 1; \
} \
Write-Host -NoNewLine 'Installing Visual Studio Build Tools ... '; \
$Process = \
Expand Down
Loading