Windows: Make sure the URL is fully formed before attempting to download #493
Conversation
|
Please also update other windows Dockerfiles too. |
| @@ -130,6 +130,14 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); | |||
| # Install Swift toolchain. | |||
| ARG SWIFT_RELEASE_METADATA=https://download.swift.org/development/windows10/latest-build.json | |||
| RUN $Release = curl.exe -sL ${env:SWIFT_RELEASE_METADATA} | ConvertFrom-JSON; \ | |||
| Write-Host ('({0})' -f $Release); \ | |||
There was a problem hiding this comment.
This will dump the json to the console - fine for debugging, but shouldn't be committed.
There was a problem hiding this comment.
@compnerd Are there any concerns about dumping the JSON file to the console? The JSON file is just a few lines long. I’m intentionally doing this so that if there are any failures, we can see what it contained and help us understand why it doesn’t contain the expected values.
There was a problem hiding this comment.
It makes it harder to see what is going on. If you want to do this at the end of the run if there are failures, that is fine, but we shouldn't do this in all cases IMO.
This should prevent the 404 errors when the URL is malformed due to `dir` and `download` fields missing.
Done! |
This should prevent the 404 errors when the URL is malformed due to
diranddownloadfields missing.